lkml.org 
[lkml]   [2008]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] Markers Implementation for Preempt RCU Boost Tracing


On Mon, 14 Jan 2008, Mathieu Desnoyers wrote:
>
> We would have to figure out if enabling -freorder-blocks-and-partition
> makes sense kernel-wide.

Last I saw, it generates crappy code, with lots more jumps back and forth,
and the image just blows up.

There's a reason we use -Os, and that's that small footprint I$ is
generally more important than fake compiler optimizations that don't
actually help except on microbenchmarks where everything fits in the
cache.

Taking a branch instruction from two bytes to five is almost always a
mistake, unless you *know* that the code it jumps to will effectively
never be done at all (which is not necessarily the case at all). It also
makes debugging much nastier, because if now things like backtraces
probably look like crap too!

Don't go there. The *best* we can do is to just use the optimizations that
generate good-looking code that humans can read. The rest is just compiler
masturbation.

Linus


\
 
 \ /
  Last update: 2008-01-14 17:35    [W:0.076 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site