[lkml]   [2008]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM without HOTPLUG_CPU

* Adrian Bunk <> wrote:

> On Thu, Jan 10, 2008 at 02:12:59PM +0100, Andi Kleen wrote:
> > Adrian Bunk <> writes:
> > >
> > > Technically you are the one who has to deal with problems in your
> > > patches, not the people pointing at the problems.
> >
> > If you believe that my patch adds a new problem then please describe
> > it clearly so that I can understand it.
> Description:
> - there are already __cpuinit* annotations in the kernel
> - on UP kernels supporting suspend/resume, such annotated code
> currently gets freed after booting (and this works)
> - with your patch applied, this code no longer gets freed

ok, i've dropped this patch from x86.git for now:

Subject: x86: force __cpuinit on for CONFIG_PM without HOTPLUG_CPU
From: Andi Kleen <>

but longer-term, shouldnt these annotations be automated? We'll see a
constant stream of them, all around the clock as people regularly get it
wrong (because it's not intuitive).


 \ /
  Last update: 2008-01-14 14:55    [W:0.235 / U:7.304 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site