lkml.org 
[lkml]   [2008]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] 8390: split up 8390 with ISA delay and 8390 without
> > diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-rc6-mm1/drivers/net/hp.c linux-2.6.24-rc6-mm1/drivers/net/hp.c
> > --- linux.vanilla-2.6.24-rc6-mm1/drivers/net/hp.c 2008-01-02 16:04:00.000000000 +0000
> > +++ linux-2.6.24-rc6-mm1/drivers/net/hp.c 2008-01-11 14:47:44.000000000 +0000
>
> > @@ -176,7 +176,7 @@
> > outb_p(irqmap[irq] | HP_RUN, ioaddr + HP_CONFIGURE);
> > outb_p( 0x00 | HP_RUN, ioaddr + HP_CONFIGURE);
>
> ... didn't you miss two here? Otherwise, code looks great.

The patch only changes the _p usage within the shared library. The hp.c
code is used solely by the ISA HP driver and needed.

> How will the user know when they need to use 8390p?

They don't need to, any more than they need to know about 8390 right now.
It is added to the Makefile so will be sucked in and built by Make as an
extra module. The 8390p and 8390 use different wrapper symbols for
ei_open etc so depmod will load the right one.

Alan


\
 
 \ /
  Last update: 2008-01-12 01:23    [W:0.042 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site