| Date | Fri, 11 Jan 2008 12:59:31 +0900 | From | KOSAKI Motohiro <> | Subject | Re: [patch 05/19] split LRU lists into anon & file sets |
| |
Hi Rik
> -static inline long mem_cgroup_calc_reclaim_inactive(struct mem_cgroup *mem, > - struct zone *zone, int priority) > +static inline long mem_cgroup_calc_reclaim(struct mem_cgroup *mem, > + struct zone *zone, int priority, > + int active, int file) > { > return 0; > }
it can't compile if memcgroup turn off.
because current mem_cgroup_calc_reclaim type is below.
long mem_cgroup_calc_reclaim(struct mem_cgroup *mem, struct zone *zone, int priority, enum lru_list lru)
after patched below, it can compile. I hope you don't think unpleasant by a trivial point out.
regard.
- kosaki
Index: linux-2.6.24-rc6-mm1-rvr/include/linux/memcontrol.h =================================================================== --- linux-2.6.24-rc6-mm1-rvr.orig/include/linux/memcontrol.h 2008-01-11 11:10:16.000000000 +0900 +++ linux-2.6.24-rc6-mm1-rvr/include/linux/memcontrol.h 2008-01-11 12:08:29.000000000 +0900 @@ -168,9 +168,8 @@ { }
-static inline long mem_cgroup_calc_reclaim(struct mem_cgroup *mem, - struct zone *zone, int priority, - int active, int file) +static inline long mem_cgroup_calc_reclaim(struct mem_cgroup *mem, struct zone *zone, + int priority, enum lru_list lru) { return 0; }
|