lkml.org 
[lkml]   [2008]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] x86: Remove ifdef from step.c
From
Date
On Thu, 2008-01-10 at 13:40 +0100, Ingo Molnar wrote:
> * Harvey Harrison <harvey.harrison@gmail.com> wrote:
>
> > @@ -148,11 +148,7 @@ static void write_debugctlmsr(struct task_struct *child, unsigned long val)
> > if (child != current)
> > return;
> >
> > -#ifdef CONFIG_X86_64
> > - wrmsrl(MSR_IA32_DEBUGCTLMSR, val);
> > -#else
> > wrmsr(MSR_IA32_DEBUGCTLMSR, val, 0);
> > -#endif
>
> doesnt this break 64-bit? 'val' is 64-bit, but wrmsr truncates it to
> 32-bit? [while wrmsrl() kept the full 64 bits]
>

I wasn't totally sure about this, but believe in this case that it is
OK. If not, we'll have to add this #ifdef back to restore_btf() in
kprobes.c which was lost Masami's unification.

But looking at how this is called, there shouldn't ever be anything in
the high 32 bits being written to (32 bit always wrote zero anyway).
In any event, it's going to be safer to use wrsmrl instead as you'll
get the zero extension on 32 bit and won't effect 64 bit.

Patch to follow.

Harvey



\
 
 \ /
  Last update: 2008-01-10 20:31    [from the cache]
©2003-2011 Jasper Spaans