lkml.org 
[lkml]   [2008]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/7] convert semaphore to mutex in struct class
On Thu, Jan 10, 2008 at 05:48:43PM +0800, Dave Young wrote:
> The patches are done on my side, please help to check.

Along with all of the other comments from people, I have a few.

> This is the first one of the series about driver core changes.
> If this one is accepted and there's no other problem I will post the others for maintainer's review (they need your comment and help because I don't know well about the specific driver logic).
>
> Thanks a lot in advance.
> ---
>
> 1. convert class semaphore to mutex.
> 2. add class iterater functions to encapsulate the detail of class devices/children list iterating :
> class_for_each_device
> class_find_device
> class_for_each_child
> class_find_child

No, please create 1 patch per type-of-change.

So in this case you would have a series of patches:
1) add the class iterator functions
2-n) convert the existing places in the kernel using the
class->semaphore to use the new iterator functions
n+1) convert class semaphore to mutex, which should only touch
the driver core

That way everything builds along the way, and it's easy to understand
and review.

Oh, and please start a new thread when you create a new patch like this
so it doesn't get burried in people's inboxes...

thanks,

greg k-h


\
 
 \ /
  Last update: 2008-01-10 19:41    [W:2.078 / U:0.648 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site