lkml.org 
[lkml]   [2008]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Change paride driver to use unlocked_ioctl instead of ioctl
    On Thu, Jan 10, 2008 at 09:01:41PM +0530, Nikanth Karthikesan wrote:
    > On Thu, 2008-01-10 at 16:01 +0100, Jiri Kosina wrote:
    > > On Wed, 9 Jan 2008, Alan Cox wrote:
    > >
    > > > > > > default:
    > > > > > > printk("%s: Unimplemented ioctl 0x%x\n", tape->name, cmd);
    > > > > > > + unlock_kernel();
    > > > > > > return -EINVAL;
    > > > > > Surely a bug ... shouldn't this return -ENOTTY?
    > > > Agreed - ENOTTY.
    > >
    > > Just out of curiosity, where does POSIX happen to specify ENOTTY as the
    > > correct one for unimplemented ioctl?
    > >
    >
    > The printk is also wrong, It should have been, Invalid ioctl for the
    > device

    It shouldn't print anything. That printk lets unprivileged users DoS
    the syslog.

    --
    Intel are signing my paycheques ... these opinions are still mine
    "Bill, look, we understand that you're interested in selling us this
    operating system, but compare it to ours. We can't possibly take such
    a retrograde step."


    \
     
     \ /
      Last update: 2008-01-10 16:53    [W:0.021 / U:30.028 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site