lkml.org 
[lkml]   [2008]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: Move get_segment_eip() to step.c

* Harvey Harrison <harvey.harrison@gmail.com> wrote:

> get_segment_eip has similarities to convert_rip_to_linear(), and is
> used in a similar context. Move get_segment_eip to step.c to allow
> easier consolidation.

thanks, applied.

> Ingo, you may want to fold this into my previous patch:
>
> x86: begin fault_{32|64}.c unification

i'd rather keep this gradual. Unless there's a lot of flip-flop this is
more maintainable. "use this new version for patch X" is harder (more
error-prone) to do for a maintainer than "please merge this new gradual
patch". We can fold too if really needed: due to bisection/build/crash
error.

Ingo


\
 
 \ /
  Last update: 2008-01-10 13:47    [W:0.044 / U:0.928 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site