Messages in this thread | | | Date | Thu, 10 Jan 2008 13:44:21 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] x86: Move get_segment_eip() to step.c |
| |
* Harvey Harrison <harvey.harrison@gmail.com> wrote:
> get_segment_eip has similarities to convert_rip_to_linear(), and is > used in a similar context. Move get_segment_eip to step.c to allow > easier consolidation.
thanks, applied.
> Ingo, you may want to fold this into my previous patch: > > x86: begin fault_{32|64}.c unification
i'd rather keep this gradual. Unless there's a lot of flip-flop this is more maintainable. "use this new version for patch X" is harder (more error-prone) to do for a maintainer than "please merge this new gradual patch". We can fold too if really needed: due to bisection/build/crash error.
Ingo
| |