lkml.org 
[lkml]   [2008]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: Remove ifdef from step.c

* Harvey Harrison <harvey.harrison@gmail.com> wrote:

> @@ -148,11 +148,7 @@ static void write_debugctlmsr(struct task_struct *child, unsigned long val)
> if (child != current)
> return;
>
> -#ifdef CONFIG_X86_64
> - wrmsrl(MSR_IA32_DEBUGCTLMSR, val);
> -#else
> wrmsr(MSR_IA32_DEBUGCTLMSR, val, 0);
> -#endif

doesnt this break 64-bit? 'val' is 64-bit, but wrmsr truncates it to
32-bit? [while wrmsrl() kept the full 64 bits]

Ingo


\
 
 \ /
  Last update: 2008-01-10 13:43    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site