Messages in this thread | | | Date | Tue, 1 Jan 2008 18:34:24 +0300 | From | Cyrill Gorcunov <> | Subject | Re: [x86] get rid of checkpatch.pl complains on apm_32.c |
| |
[Ingo Molnar - Tue, Jan 01, 2008 at 04:29:31PM +0100] | | * Cyrill Gorcunov <gorcunov@gmail.com> wrote: | | > damn me! *really* sorry for this. | | nah, this happens all the time for me too - that's why i run a script | over cleanup patches. |
yep, but i don't want to put additional work on developers so i must review the patches i'm sending *several* times at least! so that is my fault ;)
| > Ingo, do you use some script for this checking? if yes - could you | > share it? ;) (i think it's not really hard to write myown, but your | > one is really preferred ;) | | sure, pick up the script from: | | http://redhat.com/~mingo/misc/q-size-obj-compare | | it depends on having the patch in a quilt queue. (and it's really sucky, | no error checking, etc.) | | just run it - it picks up a modified .c file and compares that. If you | modify multiple files and want to check another one, give that file as | an argument to the script. | | Ingo |
thanks, Ingo.
- Cyrill -
| |