lkml.org 
[lkml]   [2008]   [Jan]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [x86] get rid of checkpatch.pl complains on apm_32.c

    * Cyrill Gorcunov <gorcunov@gmail.com> wrote:

    > This patch eliminates most of code-style errors discovered by
    > checkpatch.pl on arch/x86/kernel/apm_32.c

    looks good in principle, but the patch is not a NOP:

    text data bss dec hex filename
    12142 1837 84 14063 36ef apm_32.o.before
    12141 1837 84 14062 36ee apm_32.o.after
    md5:
    2676b881ad55e387da4a995e8b9ee372 apm_32.o.before.asm
    7fcce83dca90ded66cc43f9b4d4ca2d2 apm_32.o.after.asm

    cleanup patches should not change the resulting object code. The change
    is due to this hunk:

    @@ -1918,8 +1940,9 @@ static int __init apm_is_horked_d850md(c
    {
    if (apm_info.disabled == 0) {
    apm_info.disabled = 1;
    - printk(KERN_INFO "%s machine detected. Disabling APM.\n", d->ident);
    - printk(KERN_INFO "This bug is fixed in bios P15 which is available for \n");
    + printk(KERN_INFO "%s machine detected. "
    + "Disabling APM.\n", d->ident);
    + printk(KERN_INFO "This bug is fixed in bios P15 which is available for\n");
    printk(KERN_INFO "download from support.intel.com \n");
    }
    return 0;

    the "for \n" has been changed to "for\n". Which is an OK cleanup, but
    please do such material changes in separate patches in the future. (we
    can accept and review cleanup patches that are NOPs much easier and
    faster)

    so i removed that string change and applied your patch to x86.git, which
    is now a nice NOP:

    text data bss dec hex filename
    12142 1837 84 14063 36ef apm_32.o.before
    12142 1837 84 14063 36ef apm_32.o.after

    md5:

    2676b881ad55e387da4a995e8b9ee372 apm_32.o.before.asm
    2676b881ad55e387da4a995e8b9ee372 apm_32.o.after.asm

    Ingo


    \
     
     \ /
      Last update: 2008-01-01 16:03    [W:0.025 / U:31.192 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site