lkml.org 
[lkml]   [2008]   [Jan]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [xfs-masters] [Patch 7/8] FS: Remove 'TOPDIR' from Makefiles
    WANG Cong wrote:
    > TOPDIR is obsolete, use objtree instead.
    > This patch removes TOPDIR from all fs/ Makefiles.

    > diff --git a/fs/xfs/Makefile b/fs/xfs/Makefile
    > index 49e3e7e..d1d3d49 100644
    > --- a/fs/xfs/Makefile
    > +++ b/fs/xfs/Makefile
    > @@ -1 +1 @@
    > -include $(TOPDIR)/fs/xfs/Makefile-linux-$(VERSION).$(PATCHLEVEL)
    > +include $(objtree)/fs/xfs/Makefile-linux-$(VERSION).$(PATCHLEVEL)

    FWIW $(TOPDIR) is already banished from the latest xfs build code:

    http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/Makefile

    and the patch is in -mm too via git:

    http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc6/2.6.24-rc6-mm1/broken-out/git-xfs.patch

    Thanks,

    -Eric

    p.s. what is $(objtree) exactly? I don't see it mentioned in
    Documentation/kbuild except as one line in an example... I thought
    $(obj) and $(src) should be used outside of the core kbuild
    infrastructure, and in this case wouldn't it be $(src) anyway?



    \
     
     \ /
      Last update: 2008-01-01 18:31    [W:0.048 / U:0.248 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site