Messages in this thread |  | | | Date | Tue, 01 Jan 2008 11:27:37 -0600 | | From | Eric Sandeen <> | | Subject | Re: [xfs-masters] [Patch 7/8] FS: Remove 'TOPDIR' from Makefiles |
| |
WANG Cong wrote: > TOPDIR is obsolete, use objtree instead. > This patch removes TOPDIR from all fs/ Makefiles.
> diff --git a/fs/xfs/Makefile b/fs/xfs/Makefile > index 49e3e7e..d1d3d49 100644 > --- a/fs/xfs/Makefile > +++ b/fs/xfs/Makefile > @@ -1 +1 @@ > -include $(TOPDIR)/fs/xfs/Makefile-linux-$(VERSION).$(PATCHLEVEL) > +include $(objtree)/fs/xfs/Makefile-linux-$(VERSION).$(PATCHLEVEL)
FWIW $(TOPDIR) is already banished from the latest xfs build code:
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/Makefile
and the patch is in -mm too via git:
http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc6/2.6.24-rc6-mm1/broken-out/git-xfs.patch
Thanks,
-Eric
p.s. what is $(objtree) exactly? I don't see it mentioned in Documentation/kbuild except as one line in an example... I thought $(obj) and $(src) should be used outside of the core kbuild infrastructure, and in this case wouldn't it be $(src) anyway?
|  |