lkml.org 
[lkml]   [2007]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[-mm patch] mm/memcontrol.c: clenups
    On Fri, Aug 31, 2007 at 09:58:22PM -0700, Andrew Morton wrote:
    >...
    > Changes since 2.6.23-rc3-mm1:
    >...
    > +memory-controller-add-switch-to-control-what-type-of-pages-to-limit-v7.patch
    >...
    > memory containment
    >...

    This patch makes the following needlessly global functions static:
    - lock_page_container()
    - unlock_page_container()
    - __mem_container_move_lists()

    Additionally, there was no reason for the "mem_control_type" object.

    Signed-off-by: Adrian Bunk <bunk@kernel.org>

    ---

    mm/memcontrol.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    b582cc510b6b0a182dc56025828e7a3c566b9724
    diff --git a/mm/memcontrol.c b/mm/memcontrol.c
    index 8162d98..49bf04f 100644
    --- a/mm/memcontrol.c
    +++ b/mm/memcontrol.c
    @@ -91,7 +91,7 @@ enum {
    MEM_CONTAINER_TYPE_CACHED,
    MEM_CONTAINER_TYPE_ALL,
    MEM_CONTAINER_TYPE_MAX,
    -} mem_control_type;
    +};

    static struct mem_container init_mem_container;

    @@ -156,18 +156,18 @@ struct page_container *page_get_page_container(struct page *page)
    (page->page_container & ~PAGE_CONTAINER_LOCK);
    }

    -void __always_inline lock_page_container(struct page *page)
    +static void __always_inline lock_page_container(struct page *page)
    {
    bit_spin_lock(PAGE_CONTAINER_LOCK_BIT, &page->page_container);
    VM_BUG_ON(!page_container_locked(page));
    }

    -void __always_inline unlock_page_container(struct page *page)
    +static void __always_inline unlock_page_container(struct page *page)
    {
    bit_spin_unlock(PAGE_CONTAINER_LOCK_BIT, &page->page_container);
    }

    -void __mem_container_move_lists(struct page_container *pc, bool active)
    +static void __mem_container_move_lists(struct page_container *pc, bool active)
    {
    if (active)
    list_move(&pc->lru, &pc->mem_container->active_list);
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-09-09 22:33    [W:4.405 / U:0.352 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site