lkml.org 
[lkml]   [2007]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] net: myri10ge: force select inet_lro
From
From: Daniel Walker <dwalker@mvista.com>
Date: Fri, 07 Sep 2007 13:26:25 -0700

> This driver uses the inet_lro facilities , but it doesn't force it
> to be enabled .. Someone would have to know to enable inet_lro if
> they select the driver ..
>
> Instead, just force INET_LRO if this driver is selected..
>
> Signed-off-by: Daniel Walker <dwalker@mvista.com>

I put this exact fix into the net-2.6.24 tree several days ago
already, it's not nice that you didn't even bother checking.

When I saw the response to the help@ address, I could almost predict
that the myri10ge developers would not even check if net-2.6.24 had
the issue cured already.

Therefore, your patch doesn't even apply to the tree where it is
relevant. That sucks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-09-08 10:25    [from the cache]
©2003-2011 Jasper Spaans