lkml.org 
[lkml]   [2007]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH -mm] [RFC] IOAT: Add support for version 2 of ioatdma device
    On Thu, Sep 06, 2007 at 10:07:12AM -0700, Shannon Nelson wrote:
    > list_for_each_entry(iter, &desc->async_tx.tx_list, node) {
    > iter->hw->src_addr = addr;
    > addr += ioat_chan->xfercap;
    > +
    > + if (--cnt == 0);
    > + break;
    > }
    >
    > }
    > @@ -166,20 +177,28 @@ static void ioat_set_dest(dma_addr_t addr,
    > {
    > struct ioat_desc_sw *iter, *desc = tx_to_ioat_desc(tx);
    > struct ioat_dma_chan *ioat_chan = to_ioat_chan(tx->chan);
    > + int cnt = desc->tx_cnt;
    >
    > pci_unmap_addr_set(desc, dst, addr);
    >
    > list_for_each_entry(iter, &desc->async_tx.tx_list, node) {
    > iter->hw->dst_addr = addr;
    > addr += ioat_chan->xfercap;
    > +
    > + if (--cnt == 0);
    > + break;
    > }

    Those two look suspect to checkpatch, and I have to agree with it.

    WARNING: Trailing semicolon indicates no statements, indent implies
    otherwise
    #346: FILE: drivers/dma/ioat_dma.c:168:
    + if (--cnt == 0);
    + break;
    WARNING: Trailing semicolon indicates no statements, indent implies
    otherwise
    #363: FILE: drivers/dma/ioat_dma.c:188:
    + if (--cnt == 0);
    + break;

    -apw
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-09-07 10:47    [W:0.023 / U:0.916 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site