lkml.org 
[lkml]   [2007]   [Sep]   [7]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateFri, 07 Sep 2007 19:59:35 -0400
FromJeff Garzik <>
SubjectRe: 2.6.23-rc4-mm1 myri10ge module link error on x86_64
David Miller wrote:
> From: David Miller <davem@davemloft.net>> Date: Thu, 06 Sep 2007 13:40:38 -0700 (PDT)> >> From: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
>> Date: Thu, 6 Sep 2007 15:37:51 -0400
>>
>>> I got a link error on myri10ge when building 2.6.23-rc4-mm1 on x86_64 :
>>>>>> ERROR: "lro_flush_all" [drivers/net/myri10ge/myri10ge.ko] undefined!
>>> ERROR: "lro_receive_frags" [drivers/net/myri10ge/myri10ge.ko] undefined!
>>> make[2]: *** [__modpost] Error 1
>>> make[1]: *** [modules] Error 2
>>> make: *** [_all] Error 2
>> myri10ge needs some LRO ifdeffery.> > Actually the fix is even simpler, missing select in Kconfig.
> > I've checked the following fix for this into the net-2.6.24
> tree.> > commit 9fd380e892e078b582920325357292c07eeeecc9> Author: David S. Miller <davem@kimchee.(none)>
> Date:   Thu Sep 6 21:44:36 2007 +0100
> 
>     [MYRI10GE]: Need to select INET_LRO.
> 
>     Signed-off-by: David S. Miller <davem@davemloft.net>
> 
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index b92b7dc..7d1a84e 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -2496,6 +2496,7 @@ config MYRI10GE
>  	depends on PCI
>  	select FW_LOADER
>  	select CRC32
> +	select INET_LRO

Yes, that's the correct fix.  ACK.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-09-08 02:03    [from the cache]
©2003-2008