lkml.org 
[lkml]   [2007]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [CORRECTION][PATCH] Fix a potential NULL pointer dereference in uli526x_interrupt() in drivers/net/tulip/uli526x.c
    Micah Gruber wrote:
    > This patch fixes a potential null dereference bug where we dereference dev before a null check. This patch simply moves the dereferencing after the null check.
    >
    > Signed-off-by: Micah Gruber <micah.gruber@gmail.com>
    > ---
    >
    > --- a/drivers/net/tulip/uli526x.c
    > +++ b/drivers/net/tulip/uli526x.c
    > @@ -663,7 +663,7 @@
    > {
    > struct net_device *dev = dev_id;
    > struct uli526x_board_info *db = netdev_priv(dev);
    > - unsigned long ioaddr = dev->base_addr;
    > + unsigned long ioaddr;
    > unsigned long flags;
    >
    > if (!dev) {
    > @@ -671,6 +671,8 @@
    > return IRQ_NONE;
    > }
    >
    > + ioaddr = dev->base_addr;
    > +

    as satyam noted, just remove the !dev test


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-09-08 01:23    [W:0.021 / U:30.532 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site