Messages in this thread | | | Date | Thu, 6 Sep 2007 04:10:11 +0530 (IST) | From | Satyam Sharma <> | Subject | Re: 2.4.35.1 and panic at boot with arch=c3 and gcc-4.x |
| |
On Thu, 6 Sep 2007, Willy Tarreau wrote: > > I finally tracked the problem down to a dirty trick used to prevent > do_test_wp_bit() from being inlined (Axel, you identified the right > file). Unfortunately, this trick does not work anymore when gcc-4.x > is used without -fno-unit-at-a-time, so let's use the correct method > instead. > > > -/* Put this after the callers, so that it cannot be inlined */ > -static int do_test_wp_bit(unsigned long vaddr)
Ick, that was horrible indeed!
> I really hope that this trick is not used anywhere else!
Me too ... funnily enough, 2.6.23-rc5 still has that wrong comment in it! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |