lkml.org 
[lkml]   [2007]   [Sep]   [3]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateMon, 3 Sep 2007 08:43:13 +0200 (CEST)
FromJan Engelhardt <>
SubjectRe: [PATCH 05/32] Unionfs: do not use fsstack_copy_attr_all
On Sep 2 2007 22:20, Josef 'Jeff' Sipek wrote:
>+/* copy a/m/ctime from the lower branch with the newest times */
>+static inline void unionfs_copy_attr_times(struct inode *upper)
>+{
>
>+		/* XXX: should we notify_change on our upper inode? */

I do not think so. Inotifying should only happen when the user really 
did something (e.g. touch, cp, whatever). When merely the newest time is 
picked from a stack of files and applied to the user-visible dentry, 
nothing should happen.


	Jan
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-09-03 08:47    [from the cache]
©2003-2008