Messages in this thread | | | Date | Thu, 27 Sep 2007 13:57:39 +0900 | From | Tejun Heo <> | Subject | Re: sata_sil24 broken since 2.6.23-rc4-mm1 |
| |
Tejun Heo wrote: > Torsten Kaiser wrote: >> Comparing the driver/ata directory from rc3-mm1 and rc4-mm1 the >> following change looked the most suspicions to me: >> http://git.kernel.org/?p=linux/kernel/git/jgarzik/libata-dev.git;a=blobdiff;f=drivers/ata/sata_sil24.c;h=3dcb223117be9739ee04d70b6bfc776a4b839a3f;hp=e0cd31aa8002350add53ba6ff07493e503275244;hb=020bc1bd8d369a77bd9379cd9763ac0057651753;hpb=8d4bdf8087e682df98bdb856f6ad451bf6d597e7 >> >> That after rc4-mm1 the sata_sil24.c did not change anymore also >> matches the occurrence of the error. >> >> To confirm my theorie I exchanged the sata_sil24.c from rc8-mm1 with >> the version from rc3-mm1. >> I was able to boot the resulting kernel successfully 5 times, without >> the error happening again. > > Thanks a lot for chasing down the problem. The changed code is address > initialization path and it's weird that it causes intermittent failures, > not a consistent one. > > Anyways, does the attached patch fix the problem?
If not, can you add printk of iomap[SIL24_PORT_BAR], offset, initialized cmd_addr and scr_addr in the loop and see whether anything is different between when the driver works and fails.
Thanks.
-- tejun - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |