Messages in this thread | | | Date | Fri, 28 Sep 2007 09:08:47 +0900 | From | Paul Mundt <> | Subject | Re: [RFC] QoS params patch update. |
| |
On Thu, Sep 27, 2007 at 01:17:39PM -0700, Mark Gross wrote: > Updated qos PM parameter patch: > Note: the replacing of latency.c with this is a separate patch. > > this patch attempts to address the issues raised so far. > [snip]
> +static int register_new_qos_misc(struct qos_object *qos) > +{ > + int ret; > + > + qos->qos_power_miscdev.minor = MISC_DYNAMIC_MINOR; > + qos->qos_power_miscdev.name = qos->name; > + qos->qos_power_miscdev.fops = &qos_power_fops; > + > + ret = misc_register(&qos->qos_power_miscdev); > + > + return ret; > +} > + Minor nit, ret is a pointless variable here, you can just return misc_register directly.
Other than that, this looks much better! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |