lkml.org 
[lkml]   [2007]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: 2.6.23-rc6-mm1: Build failure on ppc64 drivers/ata/pata_scc.c
    Satyam Sharma wrote:
    > Hi,
    >
    >
    > On Thu, 20 Sep 2007, Alan Cox wrote:
    >> On Thu, 20 Sep 2007 14:13:15 +0100
    >> mel@skynet.ie (Mel Gorman) wrote:
    >>
    >>> PPC64 building allmodconfig fails to compile drivers/ata/pata_scc.c . It
    >>> doesn't show up on other arches because this driver is specific to the
    >>> architecture.
    >>>
    >>> drivers/ata/pata_scc.c: In function `scc_bmdma_status'
    >> Its not been updated to match the libata core changes. Try something like
    >> this. Whoever is maintaining it should also remove the prereset cable handling
    >> code and use the proper cable detect method.
    >
    > It appears you forgot to fix scc_std_softreset() and one of its callsites
    > in scc_bdma_stop(). A complete patch is attempted below -- please review.
    >
    >
    > [PATCH -mm] pata_scc: Keep up with libata core API changes
    >
    > Little fixlets, that the build started erroring / warning about:
    >
    > drivers/ata/pata_scc.c: In function 'scc_bmdma_status':
    > drivers/ata/pata_scc.c:734: error: structure has no member named 'active_tag'
    > drivers/ata/pata_scc.c: In function 'scc_pata_prereset':
    > drivers/ata/pata_scc.c:866: warning: passing arg 1 of 'ata_std_prereset' from incompatible pointer type
    > drivers/ata/pata_scc.c: In function 'scc_error_handler':
    > drivers/ata/pata_scc.c:908: warning: passing arg 2 of 'ata_bmdma_drive_eh' from incompatible pointer type
    > drivers/ata/pata_scc.c:908: warning: passing arg 3 of 'ata_bmdma_drive_eh' from incompatible pointer type
    > drivers/ata/pata_scc.c:908: warning: passing arg 5 of 'ata_bmdma_drive_eh' from incompatible pointer type
    > make[2]: *** [drivers/ata/pata_scc.o] Error 1
    >
    > Signed-off-by: Satyam Sharma <satyam@infradead.org>
    > Cc: Alan Cox <alan@redhat.com>
    > Cc: Mel Gorman <mel@skynet.ie>
    >
    > ---
    >
    > Andrew, this includes (supercedes) the previous two ones from Mel / Alan.
    >
    > drivers/ata/pata_scc.c | 21 ++++++++++++---------
    > 1 file changed, 12 insertions(+), 9 deletions(-)

    applied


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-09-26 05:53    [W:0.025 / U:3.800 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site