Messages in this thread | | | Date | Mon, 24 Sep 2007 12:24:22 +0200 | From | Peter Zijlstra <> | Subject | Re: [git] CFS-devel, group scheduler, fixes |
| |
On Mon, 24 Sep 2007 12:10:09 +0200 Mike Galbraith <efault@gmx.de> wrote:
> @@ -117,7 +117,7 @@ static inline struct task_struct *task_o > static inline u64 > max_vruntime(u64 min_vruntime, u64 vruntime) > { > - if ((vruntime > min_vruntime) || > + if (((s64)vruntime > (s64)min_vruntime) || > (min_vruntime > (1ULL << 61) && vruntime < (1ULL << 50))) > min_vruntime = vruntime; >
how about something like:
s64 delta = (s64)(vruntime - min_vruntime); if (delta > 0) min_vruntime += delta;
That would rid us of most of the funny conditionals there. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |