lkml.org 
[lkml]   [2007]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 1/4] module: implement module_inhibit_unload()
    From
    Date
    On Tue, 2007-09-25 at 10:40 +0900, Tejun Heo wrote:
    > Rusty Russell wrote:
    > > My concern is that you're dropping the module mutex around ->exit now.
    > > I don't *think* this should matter, but it's worth considering.
    >
    > We always did that. Before the patch the code segment looked like the
    > following.

    Hi Tejun,

    Thanks, misread patch.

    > > I really wonder if an explicit "kill_this_attribute()" is a better way
    > > to go than this...
    >
    > I think this sort of temporary unload blocking would be useful for other
    > cases like this.

    I hope not: this doesn't work in general. Calling into a module after
    ->exit has called assumes that the exit function doesn't free up or
    overwrite stuff the other functions need.

    Cheers,
    Rusty.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-09-25 04:17    [W:0.022 / U:0.784 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site