lkml.org 
[lkml]   [2007]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Uninline kcalloc()
    On 9/24/07, Valdis.Kletnieks@vt.edu <Valdis.Kletnieks@vt.edu> wrote:
    > On Sun, 23 Sep 2007 00:03:49 +0400, Alexey Dobriyan said:
    >
    > > -static inline void *kcalloc(size_t n, size_t size, gfp_t flags)
    > > -{
    > > - if (n != 0 && size > ULONG_MAX / n)
    > > - return NULL;
    > > - return __kmalloc(n * size, flags | __GFP_ZERO);
    > > -}
    > > +void *kcalloc(size_t n, size_t size, gfp_t flags);
    >
    > NAK.
    >
    > This busticates some pretty subtle code in mm/slab.c that uses
    > uses __builtin_return_address() for debugging

    Interesting. Here is output from kernel with patch applied and leak
    plugged into proc_dointvec() (I checked twice):

    $ grep kcalloc /proc/slab_allocators
    $ grep proc_dointvec /proc/slab_allocators
    size-64: 19 proc_dointvec+0x48/0xa0
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-09-24 09:47    [W:0.029 / U:0.232 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site