lkml.org 
[lkml]   [2007]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC] New kernel-message logging API

    On Sep 23 2007 10:39, Vegard Nossum wrote:
    >On 9/23/07, Joe Perches <joe@perches.com> wrote:
    >> On Sat, 2007-09-22 at 21:27 +0200, Vegard Nossum wrote:
    >> > #define kprint(fmt, ...)
    >>
    >> Good ideas. Perhaps a prefix of klog or kp_ instead?
    >> Given the number of 80 column zealots, character naming length matters.
    >
    >I don't know. Compare the following two lines:
    >
    >printk(KERN_INFO "Message.\n");
    >kprint_info("Message.");
    >
    >By dropping the lengthy macro (it's not like it's going to change
    >while we're running anyway, so why not make it a part of the function
    >name?) and the final newline, we actually end up with a net decrease
    >in line length.
    >
    >I thought it would be nice to have something that looks familiar,
    >since that would ease an eventual transition. klog is a valid
    >alternative, but isn't kp a bit cryptic?

    I'd rather fix up code to reduce its indent rather than
    trying microoptimizations at the function name level!
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-09-23 10:47    [W:0.024 / U:29.772 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site