Messages in this thread | | | Subject | RE: [PATCH 2.6.23-rc7 0/3] async_tx and md-accel fixes for 2.6.23 | Date | Fri, 21 Sep 2007 13:52:24 -0700 | From | "Williams, Dan J" <> |
| |
> From: Andrew Morton [mailto:akpm@linux-foundation.org] > > Fix a couple bugs and provide documentation for the async_tx api. > > > > Neil, please 'ack' patch #3. > > > > git://lost.foo-projects.org/~dwillia2/git/iop async-tx-fixes-for-linus > > Well it looks like Neil is on vacation or is hiding from us or something. > > In which case our options would be to go ahead and merge your #3 with > our fingers crossed, or wait and do it in 2.6.23.1 or .2. > > How serious is this bug which you're fixing? Will it affect users > of "legacy" MD setups, or only those who have enabled fancy dma-engine > features? > The symptom is raid array that fails to complete a read request.
It has only been triggered by Yuri when he tried a dma-engine configuration on his PPC platform with PAGE_SIZE=64K, this opens a large window for the bug to hit. The window is much smaller but not 100% closed in the !dma-engine case, although no one else has hit it.
2.6.22 returned reads from handle_stripe under the stripe lock so this patch can be seen as 'reverting a botched micro-optimization' versus 'introducing a new way to handle reads'.
> Either way, we need to get #2 (at least) in to Linus.
#2 is less critical and cannot hit with any of the current drivers in the kernel, so it is ok if this one misses 2.6.23. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |