lkml.org 
[lkml]   [2007]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: x86_64: potential critical issue with quicklists and page table pages
On Fri, 21 Sep 2007, Linus Torvalds wrote:

> The problem with that commit that I just reverted was that it mixed the
> two, but not completely. It still kept them separate.

The quicklists have a long history and this bug has therefore also been in
IA64 for a long time and it also likely exists on sparc64, sh and sh64. We
need the patch that I posted to fix the other platforms. And with this fix
there would be nothing amiss on x86_64 either.

---
include/linux/quicklist.h | 8 --------
1 file changed, 8 deletions(-)
Index: linux-2.6/include/linux/quicklist.h
===================================================================
--- linux-2.6.orig/include/linux/quicklist.h 2007-09-21 11:46:44.000000000 -0700
+++ linux-2.6/include/linux/quicklist.h 2007-09-21 11:55:01.000000000 -0700
@@ -56,14 +56,6 @@ static inline void __quicklist_free(int
struct page *page)
{
struct quicklist *q;
- int nid = page_to_nid(page);
-
- if (unlikely(nid != numa_node_id())) {
- if (dtor)
- dtor(p);
- __free_page(page);
- return;
- }

q = &get_cpu_var(quicklist)[nr];
*(void **)p = q->page;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2007-09-21 21:59    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site