lkml.org 
[lkml]   [2007]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] JBD: use GFP_NOFS in kmalloc
    On Sep 19, 2007  12:22 -0700, Mingming Cao wrote:
    > Convert the GFP_KERNEL flag used in JBD/JBD2 to GFP_NOFS, consistent
    > with the rest of kmalloc flag used in the JBD/JBD2 layer.
    >
    > @@ -653,7 +653,7 @@ static journal_t * journal_init_common (
    > - journal = kmalloc(sizeof(*journal), GFP_KERNEL);
    > + journal = kmalloc(sizeof(*journal), GFP_NOFS);
    > @@ -723,7 +723,7 @@ journal_t * journal_init_dev(struct bloc
    > - journal->j_wbuf = kmalloc(n * sizeof(struct buffer_head*), GFP_KERNEL);
    > + journal->j_wbuf = kmalloc(n * sizeof(struct buffer_head*), GFP_NOFS);
    > @@ -777,7 +777,7 @@ journal_t * journal_init_inode (struct i
    > - journal->j_wbuf = kmalloc(n * sizeof(struct buffer_head*), GFP_KERNEL);
    > + journal->j_wbuf = kmalloc(n * sizeof(struct buffer_head*), GFP_NOFS);

    Is there a reason for this change except "it's in a filesystem, so it
    should be GFP_NOFS"? We are only doing journal setup during mount so
    there shouldn't be any problem using GFP_KERNEL. I don't think it will
    inject any defect into the code, but I don't think it is needed either.

    Cheers, Andreas
    --
    Andreas Dilger
    Principal Software Engineer
    Cluster File Systems, Inc.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-09-20 06:27    [W:0.034 / U:363.412 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site