lkml.org 
[lkml]   [2007]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 09/15] sysfs: make bin attr open get active reference of parent too
    Date
    From
    All bin attr operations require active references of itself and its
    parent. There's no reason to allow open when its parent has been
    deactivated and allowing it is inconsistent with regular sysfs file.
    Use sysfs_get_active_two() in bin attribute open function.

    Signed-off-by: Tejun Heo <htejun@gmail.com>
    ---
    fs/sysfs/bin.c | 10 +++++-----
    1 files changed, 5 insertions(+), 5 deletions(-)

    diff --git a/fs/sysfs/bin.c b/fs/sysfs/bin.c
    index e93fe5e..9c8f882 100644
    --- a/fs/sysfs/bin.c
    +++ b/fs/sysfs/bin.c
    @@ -171,8 +171,8 @@ static int open(struct inode * inode, struct file * file)
    struct bin_buffer *bb = NULL;
    int error;

    - /* need attr_sd for attr */
    - if (!sysfs_get_active(attr_sd))
    + /* binary file operations requires both @sd and its parent */
    + if (!sysfs_get_active_two(attr_sd))
    return -ENODEV;

    error = -EACCES;
    @@ -193,12 +193,12 @@ static int open(struct inode * inode, struct file * file)
    mutex_init(&bb->mutex);
    file->private_data = bb;

    - /* open succeeded, put active reference */
    - sysfs_put_active(attr_sd);
    + /* open succeeded, put active references */
    + sysfs_put_active_two(attr_sd);
    return 0;

    err_out:
    - sysfs_put_active(attr_sd);
    + sysfs_put_active_two(attr_sd);
    kfree(bb);
    return error;
    }
    --
    1.5.0.3

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-09-20 09:11    [W:0.020 / U:31.964 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site