Messages in this thread Patch in this message | | | Date | Thu, 20 Sep 2007 17:03:52 -0500 | From | Michael Halcrow <> | Subject | Re: [PATCH 8/11] eCryptfs: Convert mmap functions to use persistent file |
| |
On Wed, Sep 19, 2007 at 10:50:57PM -0700, Andrew Morton wrote: > On Mon, 17 Sep 2007 16:50:16 -0500 Michael Halcrow <mhalcrow@us.ibm.com> wrote: > > +ecryptfs_copy_up_encrypted_with_header(struct page *page, > > + struct ecryptfs_crypt_stat *crypt_stat) > > +{ ... > > + flush_dcache_page(page); > > + if (rc) { > > + ClearPageUptodate(page); > > + printk(KERN_ERR "%s: Error reading xattr " > > + "region; rc = [%d]\n", __FUNCTION__, rc); > > + goto out; > > + } > > + SetPageUptodate(page); > > I don't know what sort of page `page' refers to here, but normally we only > manipulate the page uptodate status under lock_page().
This is the page that eCryptfs gets via ecryptfs_aops->ecryptfs_readpage(), so this should be okay. The comment should make the fact that the page is locked explicit.
Signed-off-by: Michael Halcrow <mhalcrow@us.ibm.com>
--- diff --git a/fs/ecryptfs/mmap.c b/fs/ecryptfs/mmap.c index 04103ff..c6a8a33 100644 --- a/fs/ecryptfs/mmap.c +++ b/fs/ecryptfs/mmap.c @@ -111,7 +111,7 @@ static void set_header_info(char *page_virt, * ecryptfs_copy_up_encrypted_with_header * @page: Sort of a ``virtual'' representation of the encrypted lower * file. The actual lower file does not have the metadata in - * the header. + * the header. This is locked. * @crypt_stat: The eCryptfs inode's cryptographic context * * The ``view'' is the version of the file that userspace winds up - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |