Messages in this thread | | | Date | Mon, 3 Sep 2007 04:04:14 +0530 (IST) | From | Satyam Sharma <> | Subject | Re: [PATCH -mm] sb16: Shut up uninitialized var build warning |
| |
On Mon, 3 Sep 2007, Rene Herman wrote: > > On 09/02/2007 10:15 PM, Satyam Sharma wrote: > > > sound/isa/sb16/sb16.c: In function ‘snd_sb16_isa_probe’: > > Blah. Your message has: > > Content-Type: TEXT/PLAIN; charset=iso-2022-jp > > This apparently is caused by a combination of GCC using groovy UTF tickmarks > in its error messages when in a UTF locale and alpine believing it to be a > great idea to automatically try for the "simplest" character set it can encode > the content in. No idea why that means that iso-2022-jp is picked, but it is.
Yeah, precisely.
> As to the content of this patch -- I'd almost say it's better to live with the > warning than with that unitialized_var() thing. That ARRAY_SIZE is very much a > compile time constant, so exactly how dumb must GCC get before we get to say > to here and no further?
Pretty dumb indeed -- in fact that's the case with 4 patches in this series. Like Jeff said, that (gcc's) behaviour has likely even improved w.r.t. later versions, so I guess it's fine if these 4 patches are not applied -- I'll leave it upto the maintainers.
| |