lkml.org 
[lkml]   [2007]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH -mm] sisusbvga: Fix bug and build warnings
    On 02/09/07, Satyam Sharma <satyam@infradead.org> wrote:
    >
    > drivers/usb/misc/sisusbvga/sisusb.c: In function 'usb_sisusb_init':
    > drivers/usb/misc/sisusbvga/sisusb.c:3321: warning: unused variable 'sisusb'
    > drivers/usb/misc/sisusbvga/sisusb.c:3320: warning: unused variable 'retval'
    >
    > are trivially solved by getting rid of the unused variables.
    >
    > drivers/usb/misc/sisusbvga/sisusb.c: In function 'sisusb_open':
    > drivers/usb/misc/sisusbvga/sisusb.c:2444: warning: 'sisusb' is used uninitialized in this function
    >
    > is a genuine bug (which will cause oops). We cannot use "sisusb" in
    > error path for (!interface), because sisusb will itself be derived
    > from "interface" later.
    >
    > Signed-off-by: Satyam Sharma <satyam@infradead.org>
    >
    > ---
    >
    > drivers/usb/misc/sisusbvga/sisusb.c | 7 +------
    > 1 file changed, 1 insertion(+), 6 deletions(-)
    >
    > --- linux-2.6.23-rc4-mm1/drivers/usb/misc/sisusbvga/sisusb.c‾fix 2007-09-02 19:06:01.000000000 +0530
    > +++ linux-2.6.23-rc4-mm1/drivers/usb/misc/sisusbvga/sisusb.c 2007-09-02 19:10:52.000000000 +0530
    > @@ -2440,10 +2440,8 @@ sisusb_open(struct inode *inode, struct
    > struct usb_interface *interface;
    > int subminor = iminor(inode);
    >
    > - if (!(interface = usb_find_interface(&sisusb_driver, subminor))) {
    > - dev_err(&sisusb->sisusb_dev->dev, "Failed to find interface¥n");

    Odd how in your patch the line ends with "¥n" but if I look in my
    local copy of the source tree I see "\n".


    --
    Jesper Juhl <jesper.juhl@gmail.com>
    Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
    Plain text mails only, please http://www.expita.com/nomime.html
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-09-02 22:15    [W:0.022 / U:4.428 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site