Messages in this thread Patch in this message | | | Date | Mon, 3 Sep 2007 01:43:49 +0530 (IST) | From | Satyam Sharma <> | Subject | [PATCH -mm] IPS SCSI driver: Check return of scsi_add_host() |
| |
drivers/scsi/ips.c: In function ‘ips_register_scsi’: drivers/scsi/ips.c:6869: warning: ignoring return value of ‘scsi_add_host’, declared with attribute warn_unused_result
scsi_add_host() is __must_check, so let's check it's return and cleanup appropriately on errors.
Signed-off-by: Satyam Sharma <satyam@infradead.org>
---
drivers/scsi/ips.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
--- linux-2.6.23-rc4-mm1/drivers/scsi/ips.c‾fix 2007-09-02 20:21:27.000000000 +0530 +++ linux-2.6.23-rc4-mm1/drivers/scsi/ips.c 2007-09-02 20:25:58.000000000 +0530 @@ -6866,7 +6866,12 @@ ips_register_scsi(int index) sh->max_channel = ha->nbus - 1; sh->can_queue = ha->max_cmds - 1; - scsi_add_host(sh, NULL); + if (scsi_add_host(sh, NULL)) { + IPS_PRINTK(KERN_WARNING, ha->pcidev, "Unable to add SCSI host¥n"); + free_irq(ha->irq, ha); + scsi_host_put(sh); + return -1; + } scsi_scan_host(sh); return 0;
| |