lkml.org 
[lkml]   [2007]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [05/17] vunmap: return page array
    On Tue, 18 Sep 2007 20:36:10 -0700
    Christoph Lameter <clameter@sgi.com> wrote:

    > Make vunmap return the page array that was used at vmap. This is useful
    > if one has no structures to track the page array but simply stores the
    > virtual address somewhere. The disposition of the page array can be
    > decided upon after vunmap. vfree() may now also be used instead of
    > vunmap which will release the page array after vunmap'ping it.
    >
    > Signed-off-by: Christoph Lameter <clameter@sgi.com>
    >

    Hmm, I don't like returning array which someone allocated in past and forgot.
    And, area->page[] array under vmalloc() is allocated as following (in -rc6-mm1)
    ==
    if (array_size > PAGE_SIZE) {
    pages = __vmalloc_node(array_size, gfp_mask | __GFP_ZERO,
    PAGE_KERNEL, node);
    area->flags |= VM_VPAGES;
    } else {
    pages = kmalloc_node(array_size,
    (gfp_mask & GFP_RECLAIM_MASK) | __GFP_ZERO,
    node);
    }
    ==
    A bit complicating.

    At least, please add comments "How to free page-array returned by vummap"

    Thanks,
    -Kame

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-09-19 10:07    [W:0.021 / U:183.324 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site