lkml.org 
[lkml]   [2007]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[05/17] vunmap: return page array
    Make vunmap return the page array that was used at vmap. This is useful
    if one has no structures to track the page array but simply stores the
    virtual address somewhere. The disposition of the page array can be
    decided upon after vunmap. vfree() may now also be used instead of
    vunmap which will release the page array after vunmap'ping it.

    Signed-off-by: Christoph Lameter <clameter@sgi.com>

    ---
    include/linux/vmalloc.h | 2 +-
    mm/vmalloc.c | 26 ++++++++++++++++----------
    2 files changed, 17 insertions(+), 11 deletions(-)

    Index: linux-2.6/include/linux/vmalloc.h
    ===================================================================
    --- linux-2.6.orig/include/linux/vmalloc.h 2007-09-18 13:22:56.000000000 -0700
    +++ linux-2.6/include/linux/vmalloc.h 2007-09-18 13:22:57.000000000 -0700
    @@ -49,7 +49,7 @@ extern void vfree(const void *addr);

    extern void *vmap(struct page **pages, unsigned int count,
    unsigned long flags, pgprot_t prot);
    -extern void vunmap(const void *addr);
    +extern struct page **vunmap(const void *addr);

    extern int remap_vmalloc_range(struct vm_area_struct *vma, void *addr,
    unsigned long pgoff);
    Index: linux-2.6/mm/vmalloc.c
    ===================================================================
    --- linux-2.6.orig/mm/vmalloc.c 2007-09-18 13:22:56.000000000 -0700
    +++ linux-2.6/mm/vmalloc.c 2007-09-18 13:22:57.000000000 -0700
    @@ -356,17 +356,18 @@ struct vm_struct *remove_vm_area(const v
    return v;
    }

    -static void __vunmap(const void *addr, int deallocate_pages)
    +static struct page **__vunmap(const void *addr, int deallocate_pages)
    {
    struct vm_struct *area;
    + struct page **pages;

    if (!addr)
    - return;
    + return NULL;

    if ((PAGE_SIZE-1) & (unsigned long)addr) {
    printk(KERN_ERR "Trying to vfree() bad address (%p)\n", addr);
    WARN_ON(1);
    - return;
    + return NULL;
    }

    area = remove_vm_area(addr);
    @@ -374,29 +375,30 @@ static void __vunmap(const void *addr, i
    printk(KERN_ERR "Trying to vfree() nonexistent vm area (%p)\n",
    addr);
    WARN_ON(1);
    - return;
    + return NULL;
    }

    + pages = area->pages;
    debug_check_no_locks_freed(addr, area->size);

    if (deallocate_pages) {
    int i;

    for (i = 0; i < area->nr_pages; i++) {
    - struct page *page = area->pages[i];
    + struct page *page = pages[i];

    BUG_ON(!page);
    __free_page(page);
    }

    if (area->flags & VM_VPAGES)
    - vfree(area->pages);
    + vfree(pages);
    else
    - kfree(area->pages);
    + kfree(pages);
    }

    kfree(area);
    - return;
    + return pages;
    }

    /**
    @@ -424,11 +426,13 @@ EXPORT_SYMBOL(vfree);
    * which was created from the page array passed to vmap().
    *
    * Must not be called in interrupt context.
    + *
    + * Returns a pointer to the array of pointers to page structs
    */
    -void vunmap(const void *addr)
    +struct page **vunmap(const void *addr)
    {
    BUG_ON(in_interrupt());
    - __vunmap(addr, 0);
    + return __vunmap(addr, 0);
    }
    EXPORT_SYMBOL(vunmap);

    @@ -453,6 +457,8 @@ void *vmap(struct page **pages, unsigned
    area = get_vm_area((count << PAGE_SHIFT), flags);
    if (!area)
    return NULL;
    + area->pages = pages;
    + area->nr_pages = count;
    if (map_vm_area(area, prot, &pages)) {
    vunmap(area->addr);
    return NULL;
    --
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-09-19 05:47    [W:0.023 / U:1.176 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site