lkml.org 
[lkml]   [2007]   [Sep]   [18]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    DateTue, 18 Sep 2007 06:29:19 +0200
    FromBorislav Petkov <>
    Subject[PATCH 0/2] unify DMA_..BIT_MASK definitions: v1
    These patches remove redundant DMA_..BIT_MASK definitions across two drivers.
    In this version of the patches, the computation of the bitmasks is done by
    the compiler.
    
    Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de>
    Cc: Jeremy Fitzhardinge <jeremy@goop.org>
    
    --
    Index: 23-rc6/include/linux/dma-mapping.h
    ===================================================================
    --- 23-rc6/include/linux/dma-mapping.h.orig	2007-09-17 17:48:20.000000000 +0200
    +++ 23-rc6/include/linux/dma-mapping.h	2007-09-18 06:12:33.000000000 +0200
    @@ -13,16 +13,19 @@
     	DMA_NONE = 3,
     };
     
    -#define DMA_64BIT_MASK	0xffffffffffffffffULL
    -#define DMA_48BIT_MASK	0x0000ffffffffffffULL
    -#define DMA_40BIT_MASK	0x000000ffffffffffULL
    -#define DMA_39BIT_MASK	0x0000007fffffffffULL
    -#define DMA_32BIT_MASK	0x00000000ffffffffULL
    -#define DMA_31BIT_MASK	0x000000007fffffffULL
    -#define DMA_30BIT_MASK	0x000000003fffffffULL
    -#define DMA_29BIT_MASK	0x000000001fffffffULL
    -#define DMA_28BIT_MASK	0x000000000fffffffULL
    -#define DMA_24BIT_MASK	0x0000000000ffffffULL
    +#define DMA_BIT_MASK(n)	((1ULL<<(n))-1)
    +
    +#define DMA_64BIT_MASK	DMA_BIT_MASK(64)
    +#define DMA_48BIT_MASK	DMA_BIT_MASK(48)
    +#define DMA_40BIT_MASK	DMA_BIT_MASK(40)
    +#define DMA_39BIT_MASK	DMA_BIT_MASK(39)
    +#define DMA_35BIT_MASK	DMA_BIT_MASK(35)
    +#define DMA_32BIT_MASK	DMA_BIT_MASK(32)
    +#define DMA_31BIT_MASK	DMA_BIT_MASK(31)
    +#define DMA_30BIT_MASK	DMA_BIT_MASK(30)
    +#define DMA_29BIT_MASK	DMA_BIT_MASK(29)
    +#define DMA_28BIT_MASK	DMA_BIT_MASK(28)
    +#define DMA_24BIT_MASK	DMA_BIT_MASK(24)
     
     static inline int valid_dma_direction(int dma_direction)
     {
    -- 
    Regards/Gruß,
        Boris.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    
    
    \
     
     \ /
      Last update: 2007-09-18 06:33    [from the cache]
    ©2003-2008