lkml.org 
[lkml]   [2007]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: drivers/usb/misc/emi*.c have the biggest data objects in the whole tree
    Denys Vlasenko wrote:
    > Hi Tapio,
    >
    > You are the author of these files. Are you still maintaining them?

    His newer email address that I found with Google is dead, too.

    > These two object files hold the biggest data objects in the whole
    > Linux kernel
    >
    > Basically, these are big arrays of the following structures:
    >
    > typedef struct _INTEL_HEX_RECORD
    > {
    > __u32 length;
    > __u32 address;
    > __u32 type;
    > __u8 data[MAX_INTEL_HEX_RECORD_LENGTH];
    > } INTEL_HEX_RECORD;
    >
    > I suggest the following optimizations:
    >
    > Change structure to
    >
    > typedef struct _INTEL_HEX_RECORD
    > {
    > __u8 type;
    > __u8 length;
    > __u16 address;
    > __u8 data[MAX_INTEL_HEX_RECORD_LENGTH];
    > } INTEL_HEX_RECORD __attribute__((__packed__));
    >
    > Store gzip compressed tables and unpack them at load time.
    >
    > Declare them const and __initdata.

    I have a patch somewhere that moves the firmware code to userspace and changes
    the drivers to use request_firmware().


    Regards,
    Clemens

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-09-18 14:25    [W:0.031 / U:85.992 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site