lkml.org 
[lkml]   [2007]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 01/03] kbuild, asm-values: infrastructure
    Hi Oleg.

    On Wed, Jun 13, 2007 at 01:36:51AM +0200, Oleg Verych wrote:
    > * header with widely used value definitions
    > * handle all asm-related things in one file (Makefile.asm)
    > * move some asm bits from Makefile.build there
    > (rule %.s:%.c)
    > * add script to generate headers from assembles output
    > (hopefully better output, MIPS testing/joining to all arch
    > probably needed)
    >

    Took a look at this patch at last.
    Your patch moves everything to Makefile.asm and uses a script
    to generate the offset file.

    Now where we go the step to use a script to generate the offset file
    a much simpler approach would be to move both steps to the shell script.
    So the script are called with the input file as one of the
    arguments and it spits out the resulting file to stdout.

    Doing it this way would allow the caller to have full control
    on the filenames and the current call-site in top-level Kbuild
    would still be much simpler than today.

    Moving the bits from Makefile.build that is only used for asm-offset is
    a nice cleanup and this should the script version support too.

    I see no value in renaming from asm_offset to asm_value - please drop it.
    Introducing the generic asm-values.h should wait and when you do
    you should be preapred to update all architectures (ecasue otherwise it
    will not happen).

    Sorry for the late feedback.

    Sam
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-09-16 20:31    [W:5.827 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site