lkml.org 
[lkml]   [2007]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRename asm-offsets tool or not? (Re: [patch 01/03] kbuild, asm-values: infrastructure)
From
On Sun, Sep 16, 2007 at 08:29:12PM +0200, Sam Ravnborg wrote:
> Hi Oleg.

Hallo. Nice, you are bringing it back. I'll try to have LKML-like
output this time, not a makefile mess and stuff:

[]
> I see no value in renaming from asm_offset to asm_value - please drop it.
> Introducing the generic asm-values.h should wait and when you do
> you should be preapred to update all architectures (ecasue otherwise it
> will not happen).

All archs, are using same syntax. But.

Interesting exception is MIPS, where tokens are organized and implemented
more nicely, that is where *asm-values* name coming from, actually. One
can see all that text, size, constant tokens in addition to just offsets.

So, if name change isn't worth, then OK; filename compatibility check, as
one in `linux/Kbuild', is easy to hack as well to remove.

But nice feature/tool with meaningful name and functionality is just
another thing.

Opinions?
____
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-09-16 21:19    [W:0.075 / U:0.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site