lkml.org 
[lkml]   [2007]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] Blackfin BF54x NAND Flash Controller driver
    From
    Date
    On Thu, 2007-09-13 at 04:45 -0400, Mike Frysinger wrote:
    > On 9/13/07, Andrew Morton <akpm@linux-foundation.org> wrote:
    > > On Mon, 03 Sep 2007 15:25:23 +0800 Bryan Wu <bryan.wu@analog.com> wrote:
    > > > This is the driver for latest Blackfin BF54x nand flash controller
    > > >
    > > > - use nand_chip and mtd_info common nand driver interface
    > > > - provide both PIO and dma operation
    > > > - compiled with ezkit bf548 configuration
    > > > - use hardware 1-bit ECC
    > > > - tested with YAFFS2 and can mount YAFFS2 filesystem as rootfs
    > > >
    > > > ...
    > > >
    > > > +int hardware_ecc = 0;
    > >
    > > scripts/checkpatch.pl, please.
    >
    > that isnt static so checkpatch.pl wouldnt have caught it ... it should
    > be static though of course and then checkpatch.pl would have thrown a
    > static init 0 warning :)

    Actually, it would caught by checkpatch.pl even without static.

    Andrew, I think I sent out the try#2 version of this patch which fixed
    these checkpatch.pl issues. But I will continue do some cleanup as you
    point out.

    Thanks
    -Bryan Wu
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-09-13 10:51    [W:0.025 / U:60.352 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site