Messages in this thread Patch in this message | | | Date | Wed, 12 Sep 2007 22:33:48 -0400 | From | Mark Lord <> | Subject | Re: [linux-usb-devel] spontaneous disconnect with "usb-storage: implement autosuspend" |
| |
Greg KH wrote: > > There are many regressions right now, _ONLY_ if you enable > CONFIG_USB_SUSPEND. If you disable that, your problems will go away, > right? .. > Oh, and currently no distro will enable this option due to the hardware > problems, so the only people that could get hit by this are those who > build their own kernels, and they can easily disable the option.
Ubuntu has CONFIG_USB_SUSPEND=y
There are probably lots of other distros that use it as well.
This new behaviour (failed operation of USB flash keys) is a *new* regression in 2.6.23, and we still have time to fix it by either reverting the changed functionality, or by changing the code to default OFF.
Here's my patch for 2.6.23-rc6+ :
Fix USB Storage failures.
Signed-Off-By: Mark Lord <mlord@pobox.com> ---
--- linux/drivers/usb/storage/usb.c.orig 2007-09-11 11:52:14.000000000 -0400 +++ linux/drivers/usb/storage/usb.c 2007-09-12 18:18:35.000000000 -0400 @@ -1065,7 +1065,7 @@ .pre_reset = storage_pre_reset, .post_reset = storage_post_reset, .id_table = storage_usb_ids, - .supports_autosuspend = 1, + .supports_autosuspend = 0, }; static int __init usb_stor_init(void) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |