lkml.org 
[lkml]   [2007]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 07/15] Don't return -ENOSYS as extra notes size if spufs is not loaded
    Date
    Because the SPU coredump code might be built as part of a module (spufs),
    we have a stub which is called by the coredump code, this routine then calls
    into spufs if it's loaded.

    Unfortunately the stub returns -ENOSYS if spufs is not loaded, which is
    interpreted by the coredump code as an extra note size of -38 bytes. This
    leads to a corrupt core dump.

    If spufs is not loaded there will be no SPU ELF notes to write, and so the
    extra notes size will be == 0.

    Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
    ---
    arch/powerpc/platforms/cell/spu_coredump.c | 8 ++++++--
    1 files changed, 6 insertions(+), 2 deletions(-)

    diff --git a/arch/powerpc/platforms/cell/spu_coredump.c b/arch/powerpc/platforms/cell/spu_coredump.c
    index 4fd37ff..656a8c5 100644
    --- a/arch/powerpc/platforms/cell/spu_coredump.c
    +++ b/arch/powerpc/platforms/cell/spu_coredump.c
    @@ -31,15 +31,19 @@ static DEFINE_MUTEX(spu_coredump_mutex);

    int arch_notes_size(void)
    {
    - long ret;
    + int ret;

    - ret = -ENOSYS;
    mutex_lock(&spu_coredump_mutex);
    +
    if (spu_coredump_calls && try_module_get(spu_coredump_calls->owner)) {
    ret = spu_coredump_calls->arch_notes_size();
    module_put(spu_coredump_calls->owner);
    + } else {
    + ret = 0;
    }
    +
    mutex_unlock(&spu_coredump_mutex);
    +
    return ret;
    }

    --
    1.5.1.3.g7a33b
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-09-12 09:49    [W:0.022 / U:0.128 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site