lkml.org 
[lkml]   [2007]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH resend] Fix a lock problem in generic phy code
    On Mon, Sep 10, 2007 at 08:45:50PM +0200, Hans-Jürgen Koch wrote:
    >
    > > Could you please audit all instances of physdev->lock and add
    > > _bh where necessary? I can see that at least phys_stop also
    > > needs the _bh.
    >
    > I think the patch does all that's necessary. At least, there're no error
    > messages in the logs anymore. I didn't check if there's an error on
    > unload, though.

    Sorry, but you can't rely on the non-existence of lockdep
    messages as a proof of correctness :)

    If we're going to fix the obvious bugs here, we should fix
    the subtle ones too as otherwise they'll be much harder to
    notice with this patch merged.

    Cheers,
    --
    Visit Openswan at http://www.openswan.org/
    Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
    Home Page: http://gondor.apana.org.au/~herbert/
    PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-09-11 04:23    [W:0.020 / U:31.636 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site