lkml.org 
[lkml]   [2007]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [-mm patch] mm/memcontrol.c: clenups

    On Sep 10 2007 21:58, Jan Engelhardt wrote:
    >On Sep 10 2007 13:53, Balbir Singh wrote:
    >>> --- a/mm/memcontrol.c
    >>> +++ b/mm/memcontrol.c
    >>> @@ -91,7 +91,7 @@ enum {
    >>> MEM_CONTAINER_TYPE_CACHED,
    >>> MEM_CONTAINER_TYPE_ALL,
    >>> MEM_CONTAINER_TYPE_MAX,
    >>> -} mem_control_type;
    >>> +};
    >>
    >>Not sure about this, is this the preferred style?

    Humm. Judging from the @@-line, it looks like:

    enum {
    MEM_CONTAINER_TYPE_WHATEVER
    } mem_control_type;

    making it actually a variable name. Confusing at best.


    Jan
    --
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-09-10 22:03    [W:0.019 / U:3.228 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site