Messages in this thread | | | From | Herbert Xu <> | Subject | Re: [PATCH resend] Fix a lock problem in generic phy code | Date | Mon, 10 Sep 2007 16:58:59 +0800 |
| |
Hans-J??rgen Koch <hjk@linutronix.de> wrote: > > The following patch fixes it. Tested on an AT91SAM9263-EK board, kernel 2.6.23-rc4 and -rc3-mm1.
Could you please audit all instances of physdev->lock and add _bh where necessary? I can see that at least phys_stop also needs the _bh.
We should also consider whether it makes sense to move the timer into a work queue.
Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |