lkml.org 
[lkml]   [2007]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RESEND][PATCH 0/4] Virtual Machine Time Accounting
    Avi Kivity wrote:
    > Ingo Molnar wrote:
    >> * Laurent Vivier <Laurent.Vivier@bull.net> wrote:
    >>
    >>
    >>> Ingo, please, could you have a look to these patches ?
    >>>
    >>> The aim of these four patches is to introduce Virtual Machine time
    >>> accounting.
    >>>
    >>> [PATCH 1/4] as recent CPUs introduce a third running state, after
    >>> "user" and "system", we need a new field, "guest", in cpustat to
    >>> store the time used by the CPU to run virtual CPU. Modify /proc/stat
    >>> to display this new field.
    >>>
    >>
    >> the concept certainly looks sane to me.
    >>
    >> The heavy-handed use of #ifdefs uglifies the code to a large degree,
    >> but this is not a fundamental problem: since basically all distros
    >> have KVM enabled (and lguest benefits from this too), could you just
    >> make all this new code unconditional?
    >>
    >
    > I imagine the embedded people will complain... perhaps move all the code
    > to a #ifdef section above with a full implementation and a stub
    > implementation.
    >

    I'm going to repost patches without #ifdefs for readability.
    Then we could discuss if we should introduce #ifdefs and how.

    Laurent
    --
    ------------- Laurent.Vivier@bull.net --------------
    "Software is hard" - Donald Knuth

    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2007-09-10 15:11    [W:0.022 / U:240.704 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site