lkml.org 
[lkml]   [2007]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] x86/x86-64 PCI domain support
    Andi Kleen wrote:
    >>
    >> +config PCI_DOMAINS
    >> + bool "PCI domain support"
    >> + depends on PCI
    >
    > I don't think this should be a config option.

    CONFIG_PCI_DOMAINS is referenced in arch-neutral code, so the symbol
    _must_ be defined.

    It can be hidden, perhaps, if that makes our x86 maintainer happy :)


    > But there should be a pci=... option with Documentation to turn it off at runtime

    OK


    >> +static inline int pci_proc_domain(struct pci_bus *bus)
    >> +{
    >> + return pci_domain_nr(bus);
    >> +}
    >
    > The second function is redundant?

    No, it's a hook we must implement, when CONFIG_PCI_DOMAINS is enabled.

    Jeff



    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-09-02 00:09    [W:0.029 / U:30.400 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site