lkml.org 
[lkml]   [2007]   [Aug]   [9]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
From"Mitchell Erblich" <>
SubjectQuestion: sched_rt.c : is RT check needed within a RT func? dequeue_task_rt() calls update_curr_rt() which checks for priority of RR or FIFO :
DateWed, 8 Aug 2007 21:24:57 -0700
1) * Possible wasted stats overhead during dequeue..
sched_rt.c: 
Is RT check needed within a RT func? 
dequeue_task_rt() calls update_curr_rt() 
which checks for priority of RR or FIFO.

WITHIN..
static inline void update_curr_rt(struct rq *rq)

are the two lines..
if (!task_has_rt_policy(curr))
    return;
Generally if I am reading this right, then what
 RT task is neither FIFO or RR???

Thus, I think those two lines could be removed.

2) nit....
The comment within sched_rt.c
----->   Adding/removing a task to/from a priority array:
Is placed before dequeue_task_rt() where
enqueue_task_rt() is placed above the comment
Thus, the comment should be moved above enqueue_task_rt()

Mitchell Erblich




-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-08-09 06:33    [from the cache]
©2003-2008