Messages in this thread | | | Date | Thu, 9 Aug 2007 18:18:34 +0100 | From | Andy Whitcroft <> | Subject | Re: 2.6.23-rc2-mm1 -- PPC G5 kernel compile failure (patch) |
| |
On Thu, Aug 09, 2007 at 04:20:06PM +0200, Krzysztof Helt wrote: > On Thu, 9 Aug 2007 14:04:49 +0100 > Andy Whitcroft <apw@shadowen.org> wrote: > > > Seeing the following compile error on a G5 mac: > > > > drivers/video/tdfxfb.c: In function 'tdfxfb_setup': > > drivers/video/tdfxfb.c:1341: error: 'opt' undeclared (first use in this > > function) > > drivers/video/tdfxfb.c:1341: error: (Each undeclared identifier is > > reported only once > > drivers/video/tdfxfb.c:1341: error: for each function it appears in.) > > > > This seems to be the following fragment from tdfxfb-hardware-cursor: > > > > + } else if (!strcmp(this_opt, "hwcursor")) { > > + hwcursor = simple_strtoul(opt + 9, NULL, 0); > > > > I guess the nieve fix would be s/opt/this_opt, but I am also > > suspicious of the +9 here as hwcursor is only 8 long? Now this > > seems to take a numeric value and I assume that is via hwcursor=N, > > if so then the +9 would make sense _if_ the strcmp was against > > "hwcursor=". > > > > The patch below fixes all issues you have pointed out. It also fixes > the description of the nomtrr option.
Will push this through our tests and let you know.
-apw - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |